Project

General

Profile

Feature #701

Implement limit on excessively large lookup files

Added by Luke Murphey almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Luke Murphey
Target version:
0.6
Start date:
02/18/2014
Due date:
% Done:

100%

lookup_files.zip (3.73 MB) Luke Murphey, 02/21/2014 06:30 PM

History

#1 Updated by Luke Murphey almost 11 years ago

#3 Updated by Luke Murphey almost 11 years ago

Looks like the editor can handle 10 MB files fine.

#4 Updated by Luke Murphey almost 11 years ago

Some analysis:

File Size Rows Time to Load (ms) Time to Save
101 KB 1k 209 120
1 MB 10k 452 618
10 MB 100k 2640 4486
52 MB 500k 13086 Error
103 MB 1m 30101 Did not test

It appears that large files can be loaded, but not saved. I think a limit of around 10 MB would be appropriate.

#5 Updated by Luke Murphey almost 11 years ago

  • Status changed from New to In Progress

#6 Updated by Luke Murphey almost 11 years ago

I can think of a couple ways of handling this:

  1. Implement a REST API that provides the size of the file; have the editor stop loading the file if it is too big
  2. Have the controller use a code to indicate that the file is too large; return only the first few rows

Method 1:

  • Pro: Can show the size of the file in the interface
  • Con: will add a slight latency to the UI

Method 2:

  • Pro: Allows peeking into the file (first few rows)
  • Con: Not as clean of a design (since you have to know how to interpret the response codes)

#7 Updated by Luke Murphey almost 11 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

Files are limited to 10 MB

#8 Updated by Luke Murphey almost 11 years ago

  • Target version changed from 1.0 to 0.6

Also available in: Atom PDF