Project

General

Profile

Feature #1701

Add ability to treat 400 codes as a non-failures

Added by Luke Murphey almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
01/25/2017
Due date:
% Done:

100%


Associated revisions

Revision 267 (diff)
Added by luke.murphey over 7 years ago

Added rendering of configuration for what is considered a failure

Reference #1701

Revision 268 (diff)
Added by luke.murphey over 7 years ago

Improving styling of edit link

Reference #1701

Revision 269 (diff)
Added by luke.murphey over 7 years ago

Adding saving of the macros

Reference #1701

Revision 270 (diff)
Added by luke.murphey over 7 years ago

Macro values now load correctly

Reference #1701

Revision 276 (diff)
Added by lukemurphey over 7 years ago

Improving code for modifying failure definition

Reference #1701

History

#1 Updated by Luke Murphey almost 8 years ago

I might employ a KV store lookup that allows people to declare the 400 codes that they want to be considered failures.

Other options include:
  • macro
  • CSV lookup (could have a controller which produces the appropriate file); this wouldn't replicate without a specific call though

#2 Updated by Luke Murphey over 7 years ago

  • Target version changed from 2.1 to 2.2

#3 Updated by Luke Murphey over 7 years ago

As part of this, I ought to make this an alert.

#4 Updated by Luke Murphey over 7 years ago

[Website Performance Problem]
action.email.useNSSubject = 1
alert.suppress = 0
alert.track = 1
counttype = number of events
cron_schedule = */1 * * * *
dispatch.earliest_time = -5m
dispatch.latest_time = 0
display.general.type = statistics
display.page.search.tab = statistics
enableSched = 1
quantity = 0
relation = greater than
request.ui_dispatch_app = website_monitoring
request.ui_dispatch_view = search
search = sourcetype="web_ping" (`response_codes_to_alert_on` OR timed_out=True OR total_time>`response_time_threshold`) | fillnull response_code value="Connection failed" | eval response_code=if(timed_out == "True", "Connection timed out", response_code) | stats count as count max(total_time) as max_total_time by title url response_code | eval max_total_time=round(max_total_time, 2)." ms" 

#5 Updated by Luke Murphey over 7 years ago

Best UX would be:

#6 Updated by Luke Murphey over 7 years ago

  • Subject changed from Add ability to treat 400 codes as a non-failure to Add ability to treat 400 codes as a non-failures

#7 Updated by Luke Murphey over 7 years ago

  • Status changed from New to In Progress

#9 Updated by Luke Murphey over 7 years ago

Todos:
  • Handle saving response codes
  • Handle errors
  • Loading a custom entry
  • Show message when done
  • Add input validation
  • Check permissions

#10 Updated by Luke Murphey over 7 years ago

Getting an error when either of the widgets are created.

#11 Updated by Luke Murphey over 7 years ago

Questions:

#12 Updated by Luke Murphey over 7 years ago

Error is here (promises is null):

                    var dfd = $.Deferred()
                      , inputs = this._getInputs();
                    if (inputs.length > 0) {
                        var promises = _(inputs).invoke("onInputReady");
                        $.when.apply($, promises).always(dfd.resolve)

#13 Updated by Luke Murphey over 7 years ago

The fix was to load an empty onInputReady():

response_code_input.onInputReady = function(){}
response_threshold_input.onInputReady = function(){}

#14 Updated by Luke Murphey over 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF