Project

General

Profile

Feature #2116

Feature #2108: Break up LookupEditView

Break out handsontable into a separate view

Added by Luke Murphey over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Luke Murphey
Target version:
3.0
Start date:
10/29/2017
Due date:
% Done:

100%

Associated revisions

Revision 412 (diff)
Added by lukemurphey over 6 years ago

Broke out Handsontable into a separate view

Closes #2116

Revision 430 (diff)
Added by lukemurphey over 6 years ago

Broke out Handsontable into a separate view

Closes #2116

Revision 413 (diff)
Added by lukemurphey over 6 years ago

Making lookup refresh properly

Reference #2116

Revision 431 (diff)
Added by lukemurphey over 6 years ago

Making lookup refresh properly

Reference #2116

Revision 416 (diff)
Added by lukemurphey over 6 years ago

Moving error message out from the table edit view into the lookup edit view

Reference #2116

Revision 434 (diff)
Added by lukemurphey over 6 years ago

Moving error message out from the table edit view into the lookup edit view

Reference #2116

Revision 418 (diff)
Added by lukemurphey over 6 years ago

Removing unnecesary imports

Reference #2116

Revision 436 (diff)
Added by lukemurphey over 6 years ago

Removing unnecesary imports

Reference #2116

Revision 419 (diff)
Added by lukemurphey over 6 years ago

Fixing error when adding a new row

Reference #2116

Revision 437 (diff)
Added by lukemurphey over 6 years ago

Fixing error when adding a new row

Reference #2116

Revision 420 (diff)
Added by lukemurphey over 6 years ago

Fixing hook which was wrong for the creation of new rows

Reference #2116

Revision 438 (diff)
Added by lukemurphey over 6 years ago

Fixing hook which was wrong for the creation of new rows

Reference #2116

History

#1 Updated by Luke Murphey over 6 years ago

Need to:

  • Make views use this.$el

#2 Updated by Luke Murphey over 6 years ago

Imports are not working correctly. It looks like exportation is incorrect though.

#3 Updated by Luke Murphey over 6 years ago

  • Refreshing doesn't currently work.
  • Cell editing results in a new row on KV collections
  • showWarningMessage is still in the table editor

#4 Updated by Luke Murphey over 6 years ago

  • % Done changed from 0 to 70

#5 Updated by Luke Murphey over 6 years ago

This reduces the file from ~2800 lines to ~2000.

#6 Updated by Luke Murphey over 6 years ago

Refreshing doesn't work.

Questions:
  • Is this related to one of the options?
    • Removing all options: no change
  • Does just calling render work?
    • No, same result
Observations:
  • This appears to be due to re-rendering the entire component. Re-rendering only the lookup works.

#7 Updated by Luke Murphey over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 70 to 100

Also available in: Atom PDF