Project

General

Profile

Bug #2540

App sometimes doesn't work with older versions of requests

Added by Luke Murphey almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
12/11/2019
Due date:
% Done:

100%


Associated revisions

Revision 125 (diff)
Added by luke.murphey almost 2 years ago

Removing incompatible http2lib

Reference #2540

History

#1 Updated by Luke Murphey almost 2 years ago

requires = [
'chardet>=3.0.2,<3.1.0',
'idna>=2.5,<2.9',
'urllib3>=1.21.1,<1.26,!=1.25.0,!=1.25.1',
'certifi>=2017.4.17'
]

#2 Updated by Luke Murphey almost 2 years ago

Observations:
  • Moving up the library causes the following error:
    test.run_unit:
         [exec] Traceback (most recent call last):
         [exec]   File "unit.py", line 23, in <module>
         [exec]     from google_drive_app import GoogleLookupSync, SpreadsheetInaccessible, gspread, lookupfiles
         [exec]   File "../src/bin/google_drive_app/__init__.py", line 39, in <module>
         [exec]     from oauth2client.service_account import ServiceAccountCredentials
         [exec]   File "../src/bin/google_drive_app/oauth2client/service_account.py", line 25, in <module>
         [exec]     from oauth2client import client
         [exec]   File "/Users/lmurphey/Splunk/800/etc/apps/google_drive/bin/google_drive_app/oauth2client/client.py", line 39, in <module>
         [exec]     from oauth2client import transport
         [exec]   File "/Users/lmurphey/Splunk/800/etc/apps/google_drive/bin/google_drive_app/oauth2client/transport.py", line 17, in <module>
         [exec]     import httplib2
         [exec]   File "/Users/lmurphey/Splunk/800/etc/apps/google_drive/bin/google_drive_app/httplib2/__init__.py", line 475
         [exec]     print("%s:" % h, end=" ", file=self._fp)
         [exec]                         ^
         [exec] SyntaxError: invalid syntax
    
  • The http2lib has a Python 2 and 3 version
Questions: Possible solutions:
  • Have http2lib imported after the built-in version
  • Remove http2lib entirely
    • I can remove it, but the library will still exist on hosts that already installed the app
  • Change to a supported http2lib library ** **

#3 Updated by Luke Murphey almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF