Project

General

Profile

Bug #2807

Results don't retain original sorting

Added by Luke Murphey over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Input: Web Spider
Target version:
Start date:
07/03/2020
Due date:
% Done:

100%


Associated revisions

Revision 762 (diff)
Added by luke.murphey over 4 years ago

Fixing issue where results got reordered

Closes #2807

History

#1 Updated by Luke Murphey over 4 years ago

The preview works correctly, as does the search command.

Reproduction:

This works:

| webscrape selector="tr" url="https://www.w3schools.com/html/html_tables.asp" depth_limit=25 empty_matches=0 

#2 Updated by Luke Murphey over 4 years ago

Qs:
  • Where is the ordering getting messed up?
  • Does this work if I output without using the stash writer?
    • No change
  • Does this only happen when output_fx is used?
    • No change
  • What is the relevant stack?
    • web_input.py::output_results
    • web_scraper.py::scrape_page
    • web_scraper.py::get_result_single
Obs:
  • test_scrape_page_mv might be able to detect this problem
    • Ordering looks right here actually
  • get_result_single uses an OrderedDict
  • The result is correct in get_result_single() but not in output_results()

#3 Updated by Luke Murphey over 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF