Feature #2832
Feature #2784: Ability to read multiple works
Add second work to the search URL
Start date:
07/10/2020
Due date:
% Done:
100%
History
#1
Updated by Luke Murphey almost 4 years ago
Updated by - Done The page is loaded (/work/berean-study-bible/Luke/2/12?parallel=new-testament)
- Done A verse is clicked
- Done The next/previous chapter buttons are clicked
- Done Going back through the history (and second work is dropped when you go back to a URL where the second work is not included)
- Done Parallel work is closed (URL argument is dropped)
- Done A non-parallel work is chosen
#2
Updated by Luke Murphey almost 4 years ago
Prob: Going back through the history (and second work is dropped when you go back to a URL where the second work is not included)
Qs:- How does not avoid this? The URL monitoring is part of state. You are supposed to react to the change of state.
- What condition is causing the loops?
- Is the loading of the second work
- loadSecondWorkChapter() calls setState
- [determined] What is a minimal repro?
- Load a parallel work, then press back
- Adding loading of the second work in componentDidUpdate results in endless calls
- componentDidUpdate() does get called when the URL changes
Solns:
#3
Updated by Luke Murphey almost 4 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100