Project

General

Profile

Feature #2836

Choosing a non-related work when a parallel works is already opened doesn't close the parallel work

Added by Luke Murphey almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Luke Murphey
Target version:
4.6.2
Start date:
07/11/2020
Due date:
% Done:

100%

History

#1 Updated by Luke Murphey almost 4 years ago

Repro:
  1. Open http://localhost:8081/work/antiquitates-judaicae/1/1?parallel=antiquities-of-the-jews
  2. Select abdicatus: note that second work is not closed
Obs:
  • The issue a race condition in this call: 
    •       // Drop the second work since this one is not related
      this.setState({ secondWork: null, secondWorkData: null });
      this.navigateToChapter(work);
    • navigateToChapter() immediately pops the state and loads the second work all over again
Solns:
  • Have navigateToChapter() take the second work
  • Convert this to a functional component
    • Would make the race condition less of a problem

#2 Updated by Luke Murphey almost 4 years ago

  • Parent task deleted (#2784)

#3 Updated by Luke Murphey almost 4 years ago

  • Target version changed from 4.6.1 to 4.6.2

#4 Updated by Luke Murphey almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF