Project

General

Profile

Bug #2839

jexcel fails on XSS

Added by Luke Murphey over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
07/17/2020
Due date:
% Done:

100%

Associated revisions

Revision 671 (diff)
Added by luke.murphey over 4 years ago

Updating jexcel to fix XSS issue

Closes #2839

History

#1 Updated by Luke Murphey over 4 years ago

Obs:
  • I am using updateTable() to override the cell values.
  • The cell contents are getting executed before my render even gets called.
  • This line is where the issue is coming from:
        // Append nodes to the HTML
        for (j = 0; j < obj.options.data.length; j++) {
            // Create row
            var tr = obj.createRow(j, obj.options.data[j]);
            // Append line to the table
            if (j >= startNumber && j < finalNumber) {
                obj.tbody.appendChild(tr);
            }
        }
Qs:

#2 Updated by Luke Murphey over 4 years ago

Jexcel 4 doesn't load: Module name "jsuites/dist/jsuites.css" has not been loaded yet for context: _. Use require([])

Qs:
  • Why is the module named "jsuites/dist/jsuites.css"? I don't have it under dist
  • Why is it complaining for _"
Obs:
  • jsuites is trying to load it:
if (! jSuites && typeof(require) === 'function') {
    var jSuites = require('jsuites');
    require('jsuites/dist/jsuites.css');
Solns:
  • Put jexcel in a require("jexcel") call
    • Nope
  • Move jsuites under jexcel directory
  • Remove jsuites css require call
    • This fixed it
Refs:

#3 Updated by Luke Murphey over 4 years ago

  • Status changed from New to Closed
  • Target version set to 3.4.6
  • % Done changed from 0 to 100

Also available in: Atom PDF