Project

General

Profile

Bug #2883

Search page loses context of the work

Added by Luke Murphey almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Luke Murphey
Target version:
4.7.1
Start date:
02/28/2022
Due date:
% Done:

100%

Description

Repro:

  1. Select a work
  2. Search a word
  3. Click back: note that you go to the start page

Subtasks

Bug #2884: Add support for having a second work in the READ_WORK URLClosedLuke Murphey

Bug #2885: Organize URL creation such that parameters and base URLs are broken outClosedLuke Murphey

Bug #2886: Replace URL creation to use the URLs module consistentlyClosedLuke Murphey

History

#1 Updated by Luke Murphey almost 3 years ago

Obs:
  • The link is being made to the search from src/components/WordInformation/index.jsx
  • Going back to being executed by src/components/Search/index.jsx::onClickBack()
    • This is executing READ_WORK()
  • Pushing the example state in https://github.com/remix-run/history/blob/dev/docs/navigation.md doesn't work
  • BookSidebar correctly uses state; the src/components/WordInformation/index.jsx does not.
Qs:
  • Is the issue in that the history is not being made correctly or is it that the search isn't going back correctly?
    • Seems like linkBackURL is not being constructed
  • [No] Is linkBackURL being set?
    • location.state is null
  • [Yes] Is state being set properly?
  • Is location being read properly?
  • What do I need to test?
    1. Search link to work
    2. Reader: work name change
    3. Reader: setting of URL
    4. Back button on:
      1. About page
      2. Beta code converter
      3. Contact me

#2 Updated by Luke Murphey almost 3 years ago

  • Status changed from New to Closed

Also available in: Atom PDF