Project

General

Profile

Task #2020

Modulalize view code

Added by Luke Murphey over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
09/08/2017
Due date:
% Done:

100%


Description

Switch to Backbone or Vue.js


Subtasks

Task #2053: Modularize the search viewClosed

Task #2057: Modularize the list viewClosed

Associated revisions

Revision 790 (diff)
Added by lukemurphey over 6 years ago

Removing unnecessary functions

Reference #2020

Revision 805 (diff)
Added by lukemurphey over 6 years ago

Removing unnecessary functions

Reference #2020

Revision 798 (diff)
Added by lukemurphey over 6 years ago

Added new about dialog modal

Reference #2020

Revision 813 (diff)
Added by lukemurphey over 6 years ago

Added new about dialog modal

Reference #2020

Revision 799 (diff)
Added by lukemurphey over 6 years ago

Broke the riot tags into a separate file

Reference #2020

Revision 814 (diff)
Added by lukemurphey over 6 years ago

Broke the riot tags into a separate file

Reference #2020

History

#3 Updated by Luke Murphey over 6 years ago

Possible implementation:

Phase 1:
  • About dialog
  • Content me dialog
  • Wiki dialog
  • Work info dialog
Phase 2:
  • Content view (could make loading dual works possible)
  • Select work dialog

#4 Updated by Luke Murphey over 6 years ago

Some fixes needed:

  • Need space following the progress bar
  • Need to show the title even if there is no section info
  • Fix the info dialog

#5 Updated by Luke Murphey over 6 years ago

  • Target version changed from 1.6 to 2.0

#6 Updated by Luke Murphey over 6 years ago

  • Reader view
    • Work view
    • Download ebook view
  • Search view
    • Search results
      • Search result
  • Library view
  • About view
  • Wiki info lookup view
  • Work info lookup view

#7 Updated by Luke Murphey over 6 years ago

Questions about riot:

#8 Updated by Luke Murphey over 6 years ago

Trying to figure out a way to hand results to the searchresults tag.

#9 Updated by Luke Murphey over 6 years ago

What I like:
  • Components are self-contained
What I don't like:
  • The shared code for the observable
  • The use of require.js loaded code where the dependency isn't in riot
  • The riot tags are all over the place
    • These are being loaded from a central location now
What I struggled with:
  • Tag not loading
    • Tag was not registered (missing the script for riot/tag)
    • Forgot to include the tag itself

#10 Updated by Luke Murphey over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Luke Murphey

Also available in: Atom PDF