Project

General

Profile

Task #2053

Task #2020: Modulalize view code

Modularize the search view

Added by Luke Murphey about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
2.0
Start date:
09/08/2017
Due date:
% Done:

100%

Associated revisions

Revision 785 (diff)
Added by lukemurphey about 7 years ago

Adding version of search view using riot

Reference #2053

Revision 800 (diff)
Added by lukemurphey about 7 years ago

Adding version of search view using riot

Reference #2053

Revision 787 (diff)
Added by lukemurphey about 7 years ago

Rendering the charts

Reference #2053

Revision 802 (diff)
Added by lukemurphey about 7 years ago

Rendering the charts

Reference #2053

Revision 788 (diff)
Added by lukemurphey about 7 years ago

Finalizing the search view that is based on riot

Reference #2053

Revision 803 (diff)
Added by lukemurphey about 7 years ago

Finalizing the search view that is based on riot

Reference #2053

History

#1 Updated by Luke Murphey about 7 years ago

Still need to some things

Functional
  1. Handle the overlay
  2. Update the URL
  3. Pop state on reversal
  4. Load parameters from the URL
  5. Wire-up next/previous buttons
  6. Run search automatically in defined cases
  7. Render charts (might want to convert to a mixin)
  8. Wire-up checkboxes
  9. Show error on search failures
Design questions
  1. Work in the styles
  2. Design new tests

#2 Updated by Luke Murphey about 7 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 40

#3 Updated by Luke Murphey about 7 years ago

Some functions could likely be removed:
  • contains_search_words
  • do_search
  • set_caret_at_end
  • do_fresh_search
  • do_search_next
  • do_search_previous
  • search_page_popstate

#4 Updated by Luke Murphey about 7 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 40 to 100

Also available in: Atom PDF