Bug #420
Perseus Importer Gets Nodes Out of Order
100%
Description
The Perseus importer is getting some nodes out of order and places the text node just outside of the node where is should be. The speaker in the text below is Πυθιάς but the name is after the speaker node.
<span id="verse_" class="verse_container "> <!--?xml version="1.0" encoding="utf-8"?--> <span class="verse"> <span class="milestone" data-ed="p" data-n="1" data-unit="card"></span> <span class="sp" data-n="*puqia/s"> <span class="speaker"></span></span>Πυθιάς <span class="l">πρῶτον μὲν εὐχῇ τῇδε πρεσβεύω θεῶν</span> <span class="l">τὴν πρωτόμαντιν Γαῖαν: ἐκ δὲ τῆς Θέμιν,</span>
Related issues
Associated revisions
Changed the way that the XML element appender works such that it:
1) Concatenates the contents of a the text nodes if the src and dst nodes are both text nodes
2) Shims in the node to be copied at the parent of the a text node if the node to be copied is not a text node but the dsetination isThis is part of that mitigation that closes #420
Changed the way that the XML element appender works such that it:
1) Concatenates the contents of a the text nodes if the src and dst nodes are both text nodes
2) Shims in the node to be copied at the parent of the a text node if the node to be copied is not a text node but the dsetination isThis is part of that mitigation that closes #420
Changed the way that the XML element appender works such that it:
1) Concatenates the contents of a the text nodes if the src and dst nodes are both text nodes
2) Shims in the node to be copied at the parent of the a text node if the node to be copied is not a text node but the dsetination isThis is part of that mitigation that closes #420
Card milestones are now considered chunks.
Added the option (ignore_division_markers) that causes the Perseus importer to ignore division markers.
Removed unnecessary log message indicating that no verse content existed to save.
Fixed problem when the first text node was placed in the wrong location for the first verse. This closes #420.
Division markers are now included in the resulting original content.
Card milestones are now considered chunks.
Added the option (ignore_division_markers) that causes the Perseus importer to ignore division markers.
Removed unnecessary log message indicating that no verse content existed to save.
Fixed problem when the first text node was placed in the wrong location for the first verse. This closes #420.
Division markers are now included in the resulting original content.
Card milestones are now considered chunks.
Added the option (ignore_division_markers) that causes the Perseus importer to ignore division markers.
Removed unnecessary log message indicating that no verse content existed to save.
Fixed problem when the first text node was placed in the wrong location for the first verse. This closes #420.
Division markers are now included in the resulting original content.
History
#1
Updated by Luke Murphey over 11 years ago
Updated by - Priority changed from Normal to Urgent
#2
Updated by Luke Murphey over 11 years ago
It only seems to get the first node wrong. The nodes following are correct.
The problem is that we are not handling heirarchy very well. For example, the following causes an error:
<div1 type="choral"> <div2 n="1" type="strophe"> <sp><speaker>*xoro/s</speaker>
This causes the importer to fail because the div tags are dropped yet each div tag is followed by a text node (an endline). This means that importer essentially sees a text node with a text node as its child (which should not happen).
To address this, we could either:
- Attach all XML nodes (don't filter anymore)
- Ignore text nodes under other text nodes
- Attach text nodes that appear to be in a hierarchy.
#3
Updated by Luke Murphey over 11 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100